Fix styling and move towards standard TemplateResponse

[skjnldsv]

• [ ] Requires new RENDER_AS_CLEAN template on server that provide bare minimum styling (variables only) and core js

[jancborchardt]

For the record: How it looks like now, and what we should fix:

• [ ] Viewer should span whole width and also go down to the bottom
• [ ] Prevent styling of core to leak here, as you see from the input fields and selects. Or we increase the height of the action bar and adjust that.
• [ ] Possibly we still need access to variables, but maybe not?
• [ ] Background could be fully transparent as we already have the modal background
• [ ] The actions bar should not have any gradient nor this background-image texture – maybe it could also be transparent

[szaimen]

Concerning the style of pdf.js, there was a redesign just merged here mozilla/pdf.js#11077

Maybe this change could get merged into the pdfviewer first and then see what is still broken design wise?

[skjnldsv]

Concerning the style of pdf.js, there was a redesign just merged here mozilla/pdf.js#11077

Once it's released, sure!

[szaimen]

Once it's released, sure!

v2.6.347 of pdf.js was just released 🎉

[skjnldsv]

v2.6.347 of pdf.js was just released

as alpha

[jancborchardt]

For reference, this is the small style modifications I experimented with – let’s see if they still work when we update pdf.js:

// Transparent background
body {
	background-color: transparent;
	background-image: none;
}

// Semi-transparent background for toolbars
#toolbarContainer,
.findbar,
.secondaryToolbar,
#toolbarSidebar {
	background-color: rgba(0, 0, 0, 0.85);
	background-image: none;
}

[szaimen]

For reference, this is the small style modifications I experimented with – let’s see if they still work when we update pdf.js:

// Transparent background
body {
	background-color: transparent;
	background-image: none;
}

// Semi-transparent background for toolbars
#toolbarContainer,
.findbar,
.secondaryToolbar,
#toolbarSidebar {
	background-color: rgba(0, 0, 0, 0.85);
	background-image: none;
}

I am eager to see if this still works now that #290 is merged :)

[skjnldsv]

Yep, @jancborchardt you can double check with latest master of files_pdfviewer. there is additional design changes :)