docker icon indicating copy to clipboard operation
docker copied to clipboard

Enable TLS connection for Redis

Open Ziris85 opened this issue 1 year ago • 7 comments

Hello!

This is a hopefully simple PR to allow users to configure Redis to connect to a TLS-enabled Redis endpoint. It proposes a new environment variable REDIS_PROTOCOL that can be passed to the container, and replaces all areas (that I found) where tcp:// was either hard-coded or the assumed (omitted) default. All adjustments will continue to use tcp as the default if the env var isn't passed, so this shouldn't impact existing installations.

I don't do PR's very frequently so apologies if I missed something here, but I'm interested in thoughts/feedback!

Thank you!

Ziris85 avatar Nov 16 '24 05:11 Ziris85

Hello,

I was here to add this feature, but you've done it. Do you think tat you can add suport for mTLS to ?

Seems not complicated if cert,key and ca are given with base64 string. With something like REDIS_CLIENT_CERT_BASE64 and so on ?

LordRobinCbz avatar Dec 27 '24 02:12 LordRobinCbz

I will probably add support for mTLS with Mariadb to ...

LordRobinCbz avatar Dec 27 '24 02:12 LordRobinCbz

Needs documentation in REDME

J0WI avatar Jan 11 '25 18:01 J0WI

Good point @J0WI , thanks! Just updated README for that.

Ziris85 avatar Feb 13 '25 23:02 Ziris85

This merge is of public interest. Why hasn't it been accepted yet?

geidsonc avatar Feb 20 '25 21:02 geidsonc

Is this waiting on me for anything? I'll be happy to fix/update whatever else is necessary to get this finished :slightly_smiling_face:

Ziris85 avatar Mar 11 '25 23:03 Ziris85

It needs rebase. Please only commit the docker-entrypoint.sh in the Git root, the other files are just generated.

J0WI avatar Apr 18 '25 13:04 J0WI