"Sign in via Nextcloud notification" enhancements

[jancborchardt]

• [x] The "Sign in via Nextcloud notification" notification does not have a primary button. "Approve" should be that one. :)
• [x] When clicking either "Approve" or "Deny", the notification should vanish (be marked as read). Currently it stays there
• [x] It says "Please approve or deny" but there is no "Deny" option. That should be added between "Approve" and "Mark as read"

cc @claucambra

[mbousq]

My 2 cts :

• notifications to be "always-on-top". Can't check right now, but when I had sync-errors I had to scroll down past all the errors to get to the notification. Would be easier have that notification "pinned" somehow :thinking:

[camilasan]

• [x] Since 3.6, you can not click on 'Approve' or 'Cancel'

[camilasan]

• It says "Please approve or deny" but there is no "Deny" option. That should be added between "Approve" and "Mark as read"

I think it should change on the server then. The actions provided by the api are only 'Approve' and 'Cancel'. There is no 'Deny'.

[camilasan]

[ ] When clicking either "Approve" or "Deny", the notification should vanish (be marked as read). Currently it stays there

~~this has been fixed.~~

No.

[camilasan]

[jancborchardt]

@camilasan btw is there any quite long delay in seeing this message? In practice, the Android app displays this immediately, and the desktop client does not, even after waiting 20-30 seconds.

[camilasan]

✅ There seems to be no delays on Linux and the message shows up on top. 🔴 On mac OS however, there is delay.

However, it seems to be inconsistent. I don't always get the same results in both platforms.

I will fix it in the coming days.

[jancborchardt]

@camilasan can confirm, with 3.10.1 it is now basically instant on Ubuntu 20.04. Really amazing, this makes it a looooot more seamless to sign in. :)

[camilasan]

Really amazing, this makes it a looooot more seamless to sign in. :)

Thanks for checking on Ubuntu. Amazing how it is different between platforms, it is beyond me what the difference is 🙈

[camilasan]

I have no progress on this, I was busy with support. I also asked for input from Claudio about how mac OS behaves, about the system notifications: "the system decides when to show the notification unfortunately. We might need to modify our notification system to be less spammy maybe the system is showing it late because it is throttling how many notifications reach the user (the system does this on macOS)"

But it is unknown at the moment why there is a delay to show it in the activities list (which is platform independent).

[camilasan]

When I was testing the 3.11 release on mac OS Ventura, against cloud.nextcloud.com, there was no delay at all 🤔

The exact same notification shows up on the server notifications list and when the user has seen the notification, it should then get cleared from the desktop client notification list. I am wondering if there is something wrong with that.