desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Align, resize, and layout everything uniformly in the unified search view

Open claucambra opened this issue 3 years ago • 5 comments

Addresses a point in #4434

https://user-images.githubusercontent.com/70155116/183524941-11727d68-505d-4630-9305-605bd9d9df21.mov

Screenshot 2022-08-09 at 00 22 03

claucambra avatar Aug 08 '22 22:08 claucambra

Codecov Report

Merging #4829 (1245586) into master (eb4e8ad) will increase coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head 1245586 differs from pull request most recent head 316f398. Consider uploading reports for the commit 316f398 to get more accurate results

@@           Coverage Diff           @@
##           master    #4829   +/-   ##
=======================================
  Coverage   57.17%   57.18%           
=======================================
  Files         138      138           
  Lines       17133    17133           
=======================================
+ Hits         9796     9797    +1     
+ Misses       7337     7336    -1     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 65.18% <0.00%> (+0.14%) :arrow_up:

codecov[bot] avatar Aug 08 '22 23:08 codecov[bot]

Looks very good! 2 details:

  • The content of the message doesnt need to be repeated in a tooltip/title
  • In the 3rd Talk notification (the one with the black Talk icon), the Talk icon is cut iff as it's in a circle. It should show the whole icon properly though, like for Calendar

jancborchardt avatar Aug 09 '22 22:08 jancborchardt

  • The content of the message doesnt need to be repeated in a tooltip/title

The tooltip presents the text in the unified search result fully (i.e. without eliding). Would you still want the tooltip removed?

  • In the 3rd Talk notification (the one with the black Talk icon), the Talk icon is cut iff as it's in a circle. It should show the whole icon properly though, like for Calendar

Thanks, good catch! Fixed now:

Screenshot 2022-08-10 at 14 42 15

claucambra avatar Aug 10 '22 12:08 claucambra

AppImage file: nextcloud-PR-4829-316f3981abc6a007750f81b351fd8ecbed41f2ab-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

nextcloud-desktop-bot avatar Sep 06 '22 07:09 nextcloud-desktop-bot