contacts icon indicating copy to clipboard operation
contacts copied to clipboard

don't filter results while sharing

Open avinash-0007 opened this issue 2 years ago • 1 comments

  • Share only works by display name right now

  • Search by email to share calendar is broken completely as there is a filterBy option in vue-select whose return value defaults to return (label || '').toLocaleLowerCase().indexOf(search.toLocaleLowerCase()) > -1

    • label in our code is set to displayName so only search by displayName works
  • Since we already get our results by searching(DAV & OCS), I don't see why we need the filterBy option in the first place

    • So I just make the return value true
    • In case we do need the option, we should make it check for both displayName and email attributes

same as this PR : https://github.com/nextcloud/calendar/pull/5645

avinash-0007 avatar Jan 12 '24 13:01 avinash-0007

@avinash-0007 thank you for your contribution, Can you make sure to sign off the commit, to have a green CI

hamza221 avatar Apr 02 '24 08:04 hamza221