contacts icon indicating copy to clipboard operation
contacts copied to clipboard

Enh/Enhance group information display

Open GVodyanov opened this issue 2 years ago • 1 comments

Fix https://github.com/nextcloud/contacts/issues/3706

Before After
image image

GVodyanov avatar Dec 20 '23 18:12 GVodyanov

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 2.51%. Comparing base (8c3a4f5) to head (9da6986). Report is 17 commits behind head on main.

:exclamation: Current head 9da6986 differs from pull request most recent head 0966750. Consider uploading reports for the commit 0966750 to get more accurate results

Files Patch % Lines
src/components/Properties/PropertyGroups.vue 0.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3752      +/-   ##
========================================
+ Coverage   2.44%   2.51%   +0.07%     
========================================
  Files         90      89       -1     
  Lines       4541    4414     -127     
  Branches    1163    1128      -35     
========================================
  Hits         111     111              
+ Misses      4310    4183     -127     
  Partials     120     120              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 20 '23 19:12 codecov[bot]

@GVodyanov can you please check failing CI ^^

hamza221 avatar Apr 02 '24 08:04 hamza221

@GVodyanov friendly ping , npm run lint:fix , squash , rebase

hamza221 avatar Apr 11 '24 10:04 hamza221

Sorry here I am, btw during testing I found this https://github.com/nextcloud/contacts/issues/3880, looks pretty bad @hamza221

Nvm Christoph left an explanation

GVodyanov avatar Apr 11 '24 16:04 GVodyanov

@ChristophWurst Is this the desired UI?

hamza221 avatar Apr 15 '24 16:04 hamza221

Seems find if I look at the screenshots of https://github.com/nextcloud/contacts/issues/3706

ChristophWurst avatar Apr 15 '24 16:04 ChristophWurst