contacts icon indicating copy to clipboard operation
contacts copied to clipboard

Contact v5.3.0 does not present custom "group properties" in the new UI

Open mneiger opened this issue 2 years ago • 4 comments

Describe the bug

group properties as defined in vacrd RFCs v3 used to be viewable and editable in the old UI. Now they are neither visible nor editable.

Steps to reproduce

import a vcf similar to

BEGIN:VCARD VERSION:3.0 UID:rakefet-0c992 ADR;TYPE=HOME:;;Avenue de l'AAA;Bruxelles;;1180;Belgium BDAY;VALUE=DATE:19540321 EMAIL;TYPE=HOME:[email protected] FN:Cécile Maaaak GENDER:F N:Maaaak;Cécile;;; RAK1.NICKNAME:Asher RAK2.NOTE:archivé sept 2014 RAKR.RELATED;TYPE=SPOUSE;VALUE=TEXT:Julian Serais REV;VALUE=DATE-AND-OR-TIME:20230311T095516Z TEL;TYPE=CELL:+32 48 010101001 RAK1.X-ABLABEL:Hebrew RAK2.X-ABLABEL:Rak-Note Fam END:VCARD

Expected behavior

the properties grouped as RAKxx. (RAK1, RAK2 RAKR for nickname note and related) used to be displayed and usable as supplemental fields.

it is true that such group fields are application specific and could be ignored, according to the RFC. Theses specific group properties and contact are created by an external app, but it is critical for us to be able to see these fields in nextcloud and this used to work well in the previous contact app.

Perhaps a list or regex of group could be explicitely specified in order to be allowed in nextcloud contact app. This would allow to respect the new default behaviour and avoid messing with custom data.

Actual behavior

the said fields are invisible in the UI

Contact version

5.3.0

Operating system

Mint 21.1

PHP engine version

PHP 8.1.2

Web server

Nginx

Database

MariaDB

Additional info

No response

mneiger avatar Jun 08 '23 18:06 mneiger

I've been adding custom types for phone numbers (instead default Home, Mobile, Work etc) for a long time and after upgrading to Contacts 5.3.0 I've noticed:

  • Phones with custom types neither shown nor editable
  • After creating new phone with custom type it is created with default type Home
  • After looking at the vcf file, it looks like Nextcloud's approach to storing these types has changed several times, as a result, support was completely gone

NEXTCLOUD3.GROUP4TEL:phone number GROUP1.X-ABLABEL:some text GROUP2.X-ABLABEL:some text GROUP3.X-ABLABEL:some text GROUP4.X-ABLABEL:some text NEXTCLOUD1.X-ABLABEL:some text NEXTCLOUD2.X-ABLABEL:some text NEXTCLOUD3.X-ABLABEL:some text NEXTCLOUD7.X-ABLABEL:some text NEXTCLOUD8.X-ABLABEL:some text NEXTCLOUD9.X-ABLABEL:some text NEXTCLOUD10.X-ABLABEL:some text NEXTCLOUD11.X-ABLABEL:some text NEXTCLOUD12.X-ABLABEL:some text TEL;TYPE=CELL:phone number TEL;TYPE=CELL:phone number TEL;TYPE=CELL:phone number NEXTCLOUD7.TEL;TYPE=HOME,VOICE:phone number NEXTCLOUD8.TEL;TYPE=HOME,VOICE:phone number NEXTCLOUD9.TEL;TYPE=HOME,VOICE:phone number TEL;TYPE=CELL:phone number TEL;TYPE=CELL:phone number NEXTCLOUD10.TEL;TYPE=HOME,VOICE:phone number NEXTCLOUD11.TEL;TYPE=HOME,VOICE:phone number NEXTCLOUD12.TEL;TYPE=HOME,VOICE:phone number TEL;TYPE=HOME,VOICE:phone number

This is related https://github.com/nextcloud/contacts/issues/3440

FreePlague avatar Jun 12 '23 09:06 FreePlague

I have the same effect as reported originally in #1842: custom phone types when added on the phone, after sync do not show on nextcloud in contacts 5.3.2 but they do work OK on nextcloud in contacts 4.2.5

wonder-wanderer avatar Jun 24 '23 14:06 wonder-wanderer

Any fix for that? UI is not really usable if editing contacts on e.g. an iPhone. They just disappear in the contacts UI

NotSoFunnyClown avatar Sep 19 '23 23:09 NotSoFunnyClown

Half-fix in 5.5.0. The old ones are displayed, but new ones cannot be created.

FreePlague avatar Dec 15 '23 13:12 FreePlague