Update related contacts on manager deletion

[bkrith]

Fixes: #3058

Before deletion remove property managersName reference for each related contact.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 5.12%. Comparing base (9d1befd) to head (5a29d36). Report is 1082 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #3077       +/-   ##
============================================
- Coverage     31.45%   5.12%   -26.33%     
+ Complexity      253     251        -2     
============================================
  Files           110     110               
  Lines          1863    1852       -11     
  Branches        217     217               
============================================
- Hits            586      95      -491     
- Misses         1162    1642      +480     
  Partials        115     115               

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[ChristophWurst]

@bkrith please do the following two things

1. Move sort changes out into a separate PR. We can release this fix with the next minor/major. The fix in this PR will be backported.
2. Add logic to catch externally deleted manager. This app is just one of the possible applications that access Nextcloud's CardDAV APIs. If someone deletes a manager on their phone, Thunderbird, etc, then we also don't want to cause an error. I would suggest to just ignore references to other contacts that no longer exist. We don't necessarily have to update all cards.

[ChristophWurst]

@bkrith friendly :ping_pong: . Please have a look at the review feedback above when you have time :)

[Jerome-Herbinet]

Hi @bkrith ! As @ChristophWurst said, can you take a look at the review feedback above ? Thanks !

[Adaniieel15]

Hello, I hope you are well.

In our Nextcloud instance we removed the main administrator and the org chart stopped showing.

I was wondering if they will be looking for a solution for this soon? Or if there are some steps I can take to fix it?