nextcloud
Organization chart : When a manager's contact file is deleted, it crashes the organization chart display
Describe the bug
While testing this new feature, I deleted the manager of Dark Sidious and then the chart cannot be displayed anymore. To make it appear again, I have to delete de "Manager" field entry in the Dark Sidious contact file.
Steps to reproduce
- Create an organization chart
- Delete a contact which is manager of another contact
- See that you cannot display the chart anymore
- Delete the manager field entry in the contact file which was underneath the previously deleted contact in the chart
- See that the chart can be displayed again
Expected behavior
When a "manager" contact is deleted, all dependencies should be deleted in order to avoid chart explosion.
Actual behavior
It crashes because of remaining broken dependencies.
Contact version
5.0.1
Operating system
CentOS
PHP engine version
PHP 8.0
Web server
Nginx
Database
MySQL
Additional info
No response
@bkrith any idea how we could solve this? Ignore all non-existent references when we build the graph?
Additionally, at contact deletion from within this app, we could scan all other contacts of the same address book and delete any references.
I will check it.. i think the issue is that we scan for the relationships but we don't check if the manager exists.. maybe on deletion we need to scan contacts and make null manager deleted id references.
@ChristophWurst I have a PR for this please review it when you have time. (#3077)
Tested on NC 29 30 31. Seems to fixed. Not tested on earlier versions.