calendar icon indicating copy to clipboard operation
calendar copied to clipboard

Hide e-mail controls in calendar when e-mail sending is disabled

Open pboguslawski opened this issue 3 years ago • 4 comments

This mod hides Send email checkbox from attendee context menu if dav.sendInvitations is disabled. It also replaces misleading status message about invitations already sent when adding attendee to event.

Author-Change-Id: IB#1121918 Signed-off-by: Pawel Boguslawski [email protected]

pboguslawski avatar Jul 19 '22 13:07 pboguslawski

Codecov Report

Merging #4386 (36f93cd) into main (f6ee090) will increase coverage by 0.04%. The diff coverage is 40.00%.

@@             Coverage Diff              @@
##               main    #4386      +/-   ##
============================================
+ Coverage     29.42%   29.47%   +0.04%     
  Complexity      330      330              
============================================
  Files           220      220              
  Lines          7702     7706       +4     
  Branches       1019     1017       -2     
============================================
+ Hits           2266     2271       +5     
+ Misses         5436     5435       -1     
Flag Coverage Δ
javascript 20.53% <40.00%> (+0.01%) :arrow_up:
php 68.89% <ø> (+0.08%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/components/Editor/AvatarParticipationStatus.vue 0.00% <0.00%> (ø)
...rc/components/Editor/Invitees/InviteesListItem.vue 0.00% <0.00%> (ø)
src/views/Calendar.vue 0.00% <ø> (ø)
src/store/settings.js 94.28% <100.00%> (+0.05%) :arrow_up:
...ud/apps/calendar/lib/Controller/ViewController.php 100.00% <0.00%> (ø)
...s/calendar/lib/Controller/PublicViewController.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6ee090...36f93cd. Read the comment docs.

codecov[bot] avatar Jul 19 '22 14:07 codecov[bot]

We may want to display a message on top of the attendee list: « Sending e-mail invitations to attendees is disabled by the administrator »

tcitworld avatar Jul 19 '22 14:07 tcitworld

PHP tests fail :/ also, you can lint the code base by calling composer run cs:fix so the linter check will pass.

Thanks for the PR!

miaulalala avatar Jul 20 '22 09:07 miaulalala

We may want to display a message on top of the attendee list: « Sending e-mail invitations to attendees is disabled by the administrator »

Different topic; feel free to implement this separately.

PHP tests fail :/ also, you can lint the code base by calling composer run cs:fix so the linter check will pass.

Fixed in 36f93cd8d5e2302697b98e0e68e601a41a176ba5. Please verify (not experienced in nextcloud devel).

pboguslawski avatar Jul 27 '22 09:07 pboguslawski