nextcloud
Change unselected/selected thumbnail display in Photos
Context
Now that google announced the end of free tiers photo backup, I bet more and more people will be looking for an alternative
I'd like, in the first place, to enhance the "Photos" section (like it's done on Google Photo).
Coming from Google Photo, I'd like to enhance the Photo App and I hope encouraging people/dev to enhance the Photo App to be a better Google Photo alternative with friendly UI, UX and features.
Feature
They should not impact Files section (display/features).
Implementing this 3 styles according to the 3 states of a grid item (normal/selected/non-selected)
TODO
- [x] In Photos : Applying thumbnail normal/selected behavior
- [ ] In Photos : Add small space between items
- [ ] In Files : Keep thumbnail normal/selected behavior
Concerned issues
Addressed to #6784
Testing
Writing tests is very important. Please try to write some tests for your PR. If you need help, please do not hesitate to ask in this PR for help.
unit tests instrumented tests UI tests
- [ ] Tests written, or not not needed
Looping in @tobiasKaminsky and @nextcloud/designers to make sure this is discussed and approved to not spend any efforts that need to be re-done.
Welcome :tada: and :+1: for your first contribution here :-)
We always try to follow the approach issue -> discuss -> agree on something -> pr -> merge. So in this case let us first discuss the timeline idea in a separate issue, as we want to have such features consistent across server and iOS, if possible.
As list with staggered view items is already discussed, this is good to go :+1:
Should I create a new issue for each above features ?
Yes, apart from 3 state selection, as it is this PR, and staggered item view, as this is something you can (if you want) directly do in another PR :+1:
Should I create a new issue for each above features ?
Yes, apart from 3 state selection, as it is this PR, and staggered item view, as this is something you can (if you want) directly do in another PR 👍
Done
@jancborchardt ^
Should we discuss about this in #6784 ?
@schorges those feature requests are completely unrelated to this Pull Request. Feel free to open separate issues for your requests (after searching for existing issues with this content) or upvote existing ones. Please do not spam Pull Requests with Off Topic questions 🙂 Thank you
Does this behavior should be applied on every items from "Files" part too (folders, file, photo, video, audio ) ?