Add visual hint to collapsible headers in uploads tab
The dividers / headers in the upload tab are collapsible, but I think it is missing a visual hint that it is.
The fact that I only found out about that feature after countless hours in that view underlines my point :)
Current design
I just quickly added an icon for it
@nextcloud/designers what do you think? Is that icon ok? (TODO: Color in dark theme, better alignment)
- [X] Tests written, or not not needed
Codacy
Lint
| Type | master | PR |
| Warnings | 71 | 71 |
| Errors | 3 | 3 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 67 | 67 |
| Correctness | 68 | 68 |
| Dodgy code | 350 | 350 |
| Experimental | 1 | 1 |
| Internationalization | 7 | 7 |
| Malicious code vulnerability | 2 | 2 |
| Multithreaded correctness | 6 | 6 |
| Performance | 58 | 58 |
| Security | 19 | 19 |
| Total | 578 | 578 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12847.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12847-Screenshot-blue-Light-10-10
Does anyone know if that change in the license header is the right procedure when modifying the material icon? @alperozturk96 @tobiasKaminsky @ZetaTom
Thats what it looks like now.
Codacy
Lint
| Type | master | PR |
| Warnings | 71 | 70 |
| Errors | 3 | 3 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 64 | 64 |
| Correctness | 69 | 69 |
| Dodgy code | 346 | 346 |
| Experimental | 1 | 1 |
| Internationalization | 7 | 7 |
| Malicious code vulnerability | 2 | 2 |
| Multithreaded correctness | 6 | 6 |
| Performance | 57 | 57 |
| Security | 19 | 19 |
| Total | 571 | 571 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12847.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.