android icon indicating copy to clipboard operation
android copied to clipboard

Add visual hint to collapsible headers in uploads tab

Open JonasMayerDev opened this issue 1 year ago • 3 comments

The dividers / headers in the upload tab are collapsible, but I think it is missing a visual hint that it is.

The fact that I only found out about that feature after countless hours in that view underlines my point :)

Screenshot_2024-04-09-11-25-17-06_367f977887f4a5f4712ef04f9b973e21 Current design

Screenshot_2024-04-09-11-18-53-22_06ea656a9ba653ff96746f477f32d0f9 I just quickly added an icon for it

@nextcloud/designers what do you think? Is that icon ok? (TODO: Color in dark theme, better alignment)

  • [X] Tests written, or not not needed

JonasMayerDev avatar Apr 09 '24 09:04 JonasMayerDev

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6767
Correctness6868
Dodgy code350350
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5858
Security1919
Total578578

github-actions[bot] avatar Apr 09 '24 09:04 github-actions[bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12847.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Apr 09 '24 09:04 github-actions[bot]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12847-Screenshot-blue-Light-10-10

github-actions[bot] avatar Apr 09 '24 10:04 github-actions[bot]

Does anyone know if that change in the license header is the right procedure when modifying the material icon? @alperozturk96 @tobiasKaminsky @ZetaTom

JonasMayerDev avatar May 23 '24 17:05 JonasMayerDev

Screenshot_20240528_164634

Thats what it looks like now.

JonasMayerDev avatar May 28 '24 14:05 JonasMayerDev

Codacy

Lint

TypemasterPR
Warnings7170
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6969
Dodgy code346346
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total571571

github-actions[bot] avatar May 29 '24 14:05 github-actions[bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12847.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar May 29 '24 14:05 github-actions[bot]