Check if users is set

[solracsf]

Error: Undefined array key "users" Exception: array_keys(): Argument #1 ($array) must be of type array, null given

[artonge]

In which case can it be empty? Do you have reproduction steps?

[solracsf]

No sorry, just some errors like these in the logs...

[artonge]

I am wondering if this won't juste hide another issue. Can you investigate ?

[github-actions[bot]]

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

[artonge]

Any news @solracsf ?

[solracsf]

I'm wondering if

$affectedUsers = $accessList['users'] ?? [];

could be a better solution here. Passing an empty array in case of null would not invalidate further logic in the array_merge and fix the "not an array" exception. 🤔

[artonge]

Maybe. Do you still have the log?

[solracsf]

This will also fix:

array_keys(): Argument #1 ($array) must be of type array, null given in file '/var/www/nextcloud/apps/activity/lib/FilesHooks.php' line 243"

Can we go ahead and merge + backport it?

[susnux]

I think this should be fixed in getUserPathsFromPath because there are other places where it is used

[cypress[bot]]

2 flaky tests on run #1518 ↗︎

0

10

0

0

2

Details:

Check if users is set
Project: Activity	Commit: 8304752230
Status: Passed	Duration: 03:16 💡
Started: May 7, 2024 6:35 PM	Ended: May 7, 2024 6:39 PM

  cypress/e2e/sidebar.cy.ts • 2 flaky tests • Run E2E

View Output

Test		Artifacts
Check activity listing in the sidebar > Has favorite activity		Test Replay Screenshots
Check activity listing in the sidebar > Has share activity		Test Replay Screenshots

Review all test suite changes for PR #1281 ↗︎

[susnux]

I think this should be fixed in getUserPathsFromPath because there are other places where it is used

I think this is still valid to not just hide issues

[Messj1]

@ solracsf Is this problem is related to #1056 ? Can you Check if following commit helps: 8facb65a39e4a49e11255acd417e06f3ec016f45

[solracsf]

Maybe, but as long as I don't see this in logs a long time ago, and this PR is not the good approach anyway, closing here 👍