nextcloud-libraries
Fix app settings dialog
Just for reference, the respective lines were added in https://github.com/nextcloud/nextcloud-vue/pull/2719.
The usage in Talk is AppSettingsDialog with tones of AppSettingsSection inside.
Not sure if should be necessary for an app to overwrite overflows of a stand-alone modal component? https://github.com/nextcloud/spreed/blob/d01450f87a68454a7acf6fa8e51ad8f0bec40ce6/src/components/ConversationSettings/ConversationSettingsDialog.vue
The usage in Talk is AppSettingsDialog with tones of AppSettingsSection inside.
Quite the same happens in the docs example, no?
Not sure if should be necessary for an app to overwrite overflows of a stand-alone modal component? https://github.com/nextcloud/spreed/blob/d01450f87a68454a7acf6fa8e51ad8f0bec40ce6/src/components/ConversationSettings/ConversationSettingsDialog.vue
I guess not. Does it maybe work if you remove the adjustments.
Really weird. There must be a reason, it works in the docs, but breaks with your changes.
I cloned and build the Talk app and I couldn't reproduce the scrolling issue in the settings dialog with the Talk master branch. It works just fine (besides #3029).
But I have the assumption that it could depend on how the bundler packed everything together, since this rule https://github.com/nextcloud/nextcloud-vue/blob/0324a18e33e390e27549cf2c405ed70df2d41161/src/components/AppSettingsDialog/AppSettingsDialog.vue#L362-L365 conflicts with this rule https://github.com/nextcloud/nextcloud-vue/blob/0324a18e33e390e27549cf2c405ed70df2d41161/src/components/Modal/Modal.vue#L868-L869 and the order of them in the bundle (which might vary) determines which one applies.
So the rule overwriting the style for AppSettingsDialog needs to be more specific. I will create a PR over the weekend.
Alternative solution is in https://github.com/nextcloud/nextcloud-vue/pull/3035.
Closed with https://github.com/nextcloud/nextcloud-vue/pull/3035 and https://github.com/nextcloud/spreed/pull/7745.