nextcloud-dialogs icon indicating copy to clipboard operation
nextcloud-dialogs copied to clipboard

FilePicker component can not be closed by click outside

Open Antreesy opened this issue 2 years ago • 2 comments

After merging https://github.com/nextcloud-libraries/nextcloud-vue/pull/5062 and bumping the vue-library:

  • prop closeOnClickOutside should be passed here (or be true by default): https://github.com/nextcloud-libraries/nextcloud-dialogs/blob/f69b6f18969281e48285a9a8fc984417ec3f3164/lib/components/FilePicker/FilePicker.vue#L123-L134

Antreesy avatar Jan 12 '24 11:01 Antreesy

cc @jancborchardt

I am not sure about the UX here, see also my comment here https://github.com/nextcloud-libraries/nextcloud-vue/pull/5062#issuecomment-1890460961

susnux avatar Jan 13 '24 13:01 susnux

cc @nextcloud-libraries/developers

susnux avatar Apr 02 '24 14:04 susnux

Agree with @susnux’s assessment in https://github.com/nextcloud-libraries/nextcloud-vue/pull/5062#issuecomment-1890460961 – it is too risky and annoying to have changes vanish by accidentally clicking or tapping outside, even if it is just navigating into a sub-sub-subfolder and finally finding the file you were looking for. The X button is there and always there, it doesn’t need a huge "CLOSE" area around the whole dialog too. :)

jancborchardt avatar Aug 19 '24 12:08 jancborchardt

Ok, then I'm closing it

Antreesy avatar Aug 19 '24 12:08 Antreesy