nexB
Add curl advisories importer
This pr resolves the issue #1166.
The advisories were added properly and the site was working fine. I also registered the importer in the init.py file.
@TG1999 please let me know if there are any further changes and everything is correct or not.
@ambuj-1211 please add a curl improver to the valid_versions.py
ex: https://github.com/nexB/vulnerablecode/blob/main/vulnerabilities/improvers/valid_versions.py#L472
work! just a few nits for your consi
I think you tagged someone else in this comment, is it a mistake? And I am working on the changes now.
work! just a few nits for your consi
I think you tagged someone else in this comment, is it a mistake? And I am working on the changes now.
sorry it was a mistake and I fixed it
@ambuj-1211 Absolutely! Once all the changes are in place, squashing them into a single commit before merging will create a cleaner history for everyone.
to fix the test update the vulnerabilities/tests/test_data/curl/expected-curl-advisory-output.json
and it would be good if you add more test examples :
vulnerabilities/tests/test_data/curl/expected-curl-advisory-output1.json
vulnerabilities/tests/test_data/curl/expected-curl-advisory-output2.json
@ziadhany @TG1999 i have made all the required changes and squashed all the commits to make the history clean, moreover I also had updated my branch according to the main branch. Please review it.
@ziadhany some checks are not successfull but they are because of openssl url do I need to change it to some thing, I am asking because it is not related to curl advisories.
@ziadhany some checks are not successfull but they are because of openssl url do I need to change it to some thing, I am asking because it is not related to curl advisories.
@ambuj-1211 No, this is the docs test ( not related to this pull request )
@ziadhany check the files now I have changed the files and squashed the commits, I think now the history and everything is clean and good to go, please let me know if there are any more nits.
@ziadhany is this PR good to merge, if yes please merge this in. Thanks!
@TG1999 Yes, I have reviewed this pull request several times and I believe we should merge it.