scancode-workbench icon indicating copy to clipboard operation
scancode-workbench copied to clipboard
verified publisher icon nexB

Support latest scancode toolkit

Open OmkarPh opened this issue 3 years ago • 1 comments

Description

  • Workbench doesn't support json files from latest scancode toolkit due to lack of updates
  • Sqlite can be updated to support latest output json documented here: https://scancodeio.readthedocs.io/en/latest/output-files.html
  • Format mismatch causes errors like this: https://github.com/nexB/scancode-workbench/issues/522

OmkarPh avatar May 18 '22 05:05 OmkarPh

Update - WIP in branch v4.0-react-typescript

OmkarPh avatar Aug 30 '22 06:08 OmkarPh

In my testing, latest release of ScanCode Workbench v3.1.1 works well with output from ScanCode Toolkit v30.1.0, but not with output from v31.x.y series.

When used with output from v31.x.y series, it just does not "see" or report any licenses or copyrights. Visualization only tracks directories/files, but no properties 'discovered' for them. The data is in the JSON file, but is not parsed by Workbench.

martin-langhoff avatar Dec 01 '22 21:12 martin-langhoff

@martin-langhoff This is correct, we have an updated branch that is pending last mile review before merging. Can you give a shot to https://github.com/nexB/scancode-workbench/pull/532 (only if you feel comfy with building from sources)

pombredanne avatar Dec 01 '22 21:12 pombredanne

@pombredanne thanks for the update. I am more than happy to build from source but current master is pretty broken for me when building on Mac OS. node-gyp spews all over. I'll try on the PR branch you are suggesting and report on the PR itself.

martin-langhoff avatar Dec 01 '22 22:12 martin-langhoff

Testing your PR

  • branch builds on my Mac OS 12.6.1 with Node from Brew (whereas develop is broken on node-gyp)
  • tested with an input report.json built with latest 'develop' commit in scancode-toolkit, the test run was over the git source code repo
  • Import worked well
  • In dashboard, Copyright Holders looks a bit odd (screencap below)
  • License info dashboard had no data, this is incorrect (JSON file has license data)

image

martin-langhoff avatar Dec 01 '22 23:12 martin-langhoff

(posted same message on #532 )

martin-langhoff avatar Dec 01 '22 23:12 martin-langhoff

@martin-langhoff Thank you ++ for testing. The issue is that we are in the process to update the data format for ScanCode licenses in the develop branch. @AyanSinhaMahapatra ping

pombredanne avatar Dec 04 '22 14:12 pombredanne

This is now completed with https://github.com/nexB/scancode-workbench/releases/tag/v4.0.0rc2 supporting the latest scancode-toolkit v32.x output format, code is at https://github.com/nexB/scancode-workbench/tree/v4.0-react-typescript

@martin-langhoff please do test this out :rocket:

AyanSinhaMahapatra avatar Apr 14 '23 11:04 AyanSinhaMahapatra