mapael-maps icon indicating copy to clipboard operation
mapael-maps copied to clipboard

Create lugansk_region.js

Open sergey-lisitsyn opened this issue 7 years ago • 2 comments

sergey-lisitsyn avatar Sep 08 '18 13:09 sergey-lisitsyn

Hello @SergeyLisitsyn ,

All seems to be ok to me, thanks for you contribution. Do you plan to implement the getCoords() function, or do I merge your pull-request without it ?

neveldo avatar Sep 13 '18 16:09 neveldo

Hi, Vincent Brouté, I am new in that and I'm not sure if that map is right generated. I prefer to wait until customer check out the map. Thanks, I forgot to put in js file getCoords() function despite I created it earlier. I think, I will fix all issues and will commit a new file version. Thank you for comprehension.

Sergey.

P.S. l will plan continue to make all provinces of Ukraine further if my project will continue too.

On Thu, Sep 13, 2018, 19:33 Vincent Brouté [email protected] wrote:

Hello @SergeyLisitsyn https://github.com/SergeyLisitsyn ,

All seems to be ok to me, thanks for you contribution. Do you plan to implement the getCoords() function, or do I merge your pull-request without it ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/neveldo/mapael-maps/pull/55#issuecomment-421069878, or mute the thread https://github.com/notifications/unsubscribe-auth/AGHOAzj-lbPD_r1lcQmDOp-aJrILcMwMks5uaojHgaJpZM4Wf32_ .

sergey-lisitsyn avatar Sep 13 '18 21:09 sergey-lisitsyn