hyppo icon indicating copy to clipboard operation
hyppo copied to clipboard

Conditional Correlation Tests

Open j1c opened this issue 3 years ago • 5 comments

Reference issue

Closes #332

Type of change

Addition of three correlation based conditional independence tests.

  1. Partial pearson correlation test (univariate only)
  2. Partial distance correlation (Szekely 2014)
  3. Conditional distance correlation (Wang 2015)

Others

  1. Simulations for conditional independence
  2. Power curves for partial dcorr and conditional dcorr
  3. Tests

Additional information

Few functions in tools were changed to accommodate for three input data matrices.

  1. compute_dist
  2. _check_distmat
  3. _perm_stat
  4. perm_test

j1c avatar Jan 31 '23 16:01 j1c

Deploy Preview for hyppo ready!

Name Link
Latest commit 89910e27909f1831ee4885fe4abc220a9f3fb541
Latest deploy log https://app.netlify.com/sites/hyppo/deploys/66df0968937455000937001e
Deploy Preview https://deploy-preview-349--hyppo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 31 '23 16:01 netlify[bot]

Codecov Report

Attention: Patch coverage is 97.28000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 96.79%. Comparing base (8f12a27) to head (89910e2). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hyppo/conditional/_utils.py 92.06% 5 Missing :warning:
hyppo/conditional/cdcorr.py 93.67% 5 Missing :warning:
hyppo/tools/power.py 77.77% 4 Missing :warning:
hyppo/conditional/tests/test_utils.py 95.65% 2 Missing :warning:
hyppo/conditional/pdcorr.py 97.50% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   96.70%   96.79%   +0.09%     
==========================================
  Files          86       96      +10     
  Lines        3879     4490     +611     
==========================================
+ Hits         3751     4346     +595     
- Misses        128      144      +16     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 08 '23 22:03 codecov[bot]

@j1c The only thing missing is a few unit tests for some of the error checks. Once those are added, I'll merge

sampan501 avatar Oct 19 '23 14:10 sampan501

@j1c Let me know when you believe that everything looks good and I'll review

sampan501 avatar Jan 12 '24 13:01 sampan501

@j1c Let me know when you believe that everything looks good and I'll review

This is good to go.

j1c avatar Jan 29 '24 20:01 j1c