brainlit icon indicating copy to clipboard operation
brainlit copied to clipboard

adapt algorithms and preprocessing/features

Open bvarjavand opened this issue 5 years ago • 2 comments

Scripts in the above folders are built on top of utils, so when utils changed some broke. This is mainly fixing imports and modifying parameter inputs.

bvarjavand avatar Aug 07 '20 18:08 bvarjavand

tell them where the problems are, etc.

jovo avatar Aug 07 '20 19:08 jovo

we want to modify lines like these https://github.com/neurodata/brainlit/blob/develop/brainlit/preprocessing/features/base.py#L96

note how it uses a segments_url kwarg instead of the correct url_segments kwarg.

We want to update methods in the following files

  • [ ] https://github.com/neurodata/brainlit/blob/develop/brainlit/preprocessing/features/base.py
  • [ ] https://github.com/neurodata/brainlit/blob/develop/brainlit/preprocessing/features/linear_features.py
  • [ ] https://github.com/neurodata/brainlit/blob/develop/brainlit/preprocessing/features/neigborhood.py
  • [ ] https://github.com/neurodata/brainlit/blob/develop/brainlit/algorithms/generate_fragments/adaptive_thresh.py

bvarjavand avatar Aug 08 '20 00:08 bvarjavand