ntc-templates icon indicating copy to clipboard operation
ntc-templates copied to clipboard

Update Huawei VRP display vlan

Open evilmonkey19 opened this issue 1 year ago • 6 comments

Adding support for AP. I accept suggestions for VLAN_ID and VLAN_TYPE

evilmonkey19 avatar Feb 07 '25 12:02 evilmonkey19

This templates are for Huawei VRP platform, which is used in Huawei Switches and APs. The command display vlan is used in both platforms, but they have similar but not exactly the same values. Also I decided to use a more common approach on display vlan imitating show etherchannel brief from cisco IOS.

As well, I added the command display vlan brief which is used in Huawei VRP AP. I reused a template from display vlan.

evilmonkey19 avatar Feb 08 '25 15:02 evilmonkey19

This templates are for Huawei VRP platform, which is used in Huawei Switches and APs. The command display vlan is used in both platforms, but they have similar but not exactly the same values. Also I decided to use a more common approach on display vlan imitating show etherchannel brief from cisco IOS.

I'm curious, so I looked but didn't find a template for etherchannel brief, but there is one for summary.

Did I miss something?

Thank you.

As well, I added the command display vlan brief which is used in Huawei VRP AP. I reused a template from display vlan.

mjbear avatar Feb 08 '25 18:02 mjbear

I'm working on getting some additional eyes on this one. This does look like a breaking change at the moment. Which then we need to do a major release here soon.

jvanderaa avatar Feb 11 '25 14:02 jvanderaa

What information does bried have that hte regular does not? In general, I regret supporting things like "show cdp neighbors" and "show cdp neighbors details". It's extra work and you get everything from details, no exceptions. The compute cost of a few extra lines is so small, it's not worth the development effort and upkeep.

itdependsnetworks avatar Feb 11 '25 23:02 itdependsnetworks

The issue here is not that we are adding extra little details. Myself, I'm configuring Huawei AP and Huawei switches (VRP). Both cases they do have SSH and in both cases the command is the same. However the output isn't, that's why I suggest doing that.

Also, I wanted to make the command more standard similar to show etherchannel brief (or similar).

evilmonkey19 avatar Feb 17 '25 16:02 evilmonkey19

The issue here is not that we are adding extra little details. Myself, I'm configuring Huawei AP and Huawei switches (VRP). Both cases they do have SSH and in both cases the command is the same. However the output isn't, that's why I suggest doing that.

Also, I wanted to make the command more standard similar to show etherchannel brief (or similar).

What Ken is suggesting is that we shouldn't unnecessarily create templates for the "brief" or "summary" commands (or their vendor/platform equivalents).

A template for the normal or detailed version of the command means one template that provides the same information (and more) plus it means one template to maintain and not two in the long term.

mjbear avatar Feb 17 '25 17:02 mjbear

I resolved an index merge conflict (that's the Merge branch 'master' commit) Thank you.

mjbear avatar Jun 15 '25 16:06 mjbear