ntc-templates icon indicating copy to clipboard operation
ntc-templates copied to clipboard

Fix typos and issues in fortinet_get_system_status for FortiGate 7.2 VM

Open glennake opened this issue 1 year ago • 2 comments

glennake avatar Jul 21 '24 19:07 glennake

Thanks for the PR @glennake

For updates to existing templates, the test data for those templates will need to be updated to reflect the changes.

https://github.com/networktocode/ntc-templates/blob/master/docs/dev/dev_parser.md#development-helper-scripts

For new templates, we require test cases be included in the PR,

https://github.com/networktocode/ntc-templates/blob/master/docs/dev/dev_parser.md#tests https://github.com/networktocode/ntc-templates/blob/master/docs/user/faq.md#i-simply-want-to-add-my-template-to-the-project-i-do-not-want-to-add-all-of-these-tests-and-controls-can-i-just-do-so

and we now require that every state provide a final line ^. -> Error to ensure that we are capturing the data.

https://github.com/networktocode/ntc-templates/blob/master/docs/user/faq.md#why-is-there-a-requirement-to-use-error-in-every-template

Hopefully the above hyperlinks to documentation helps. :dart: There isn't much effort left from you @glennake to complete the requirements so this pull request (PR) could be reviewed and merged in!

mjbear avatar Aug 04 '24 18:08 mjbear

@glennake are you still interested in seeing this PR completed?

jmcgill298 avatar Aug 15 '24 13:08 jmcgill298

@pnpestov Might you be willing to contribute test data (raw command output) so I can help close this?

  • fortinet_get_system_status
  • fortinet_get_router_info_ospf_neighbor

mjbear avatar Oct 11 '24 10:10 mjbear

Might you be willing to contribute test data (raw command output) so I can help close this?

@mjbear Good day! Yes, I can, but we have practically moved away from the OSPF protocol. The received data is attached. Other.zip

pnpestov avatar Oct 11 '24 11:10 pnpestov

resolved by #1873

mjbear avatar Oct 12 '24 00:10 mjbear