json-schema-validator icon indicating copy to clipboard operation
json-schema-validator copied to clipboard

$ref to github

Open mahirgamal opened this issue 3 years ago • 3 comments

Hi,

I am trying this code: "$ref": "https://github.com/adewg/ICAR/blob/3340b2041f73afe47079426588bcef1eaf2b004e/enums/icarDepartureKindType.json",

but always getting this error: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (JSON String, Number, Array, Object or token 'null', 'true' or 'false') at [Source: (sun.net.www.protocol.http.HttpURLConnection$HttpInputStream); line: 7, column: 2]

and when I am testing locally it works perfect, any idea what's wrong?

image

cheers,

mahirgamal avatar May 12 '22 16:05 mahirgamal

We have some issues connecting to the HTTPS site with the client.truststore configuration. This is the reason we need to move to Java 11 so that we can use the JDK 11 HTTP client instead of HttpConnection in Java 8, which is very limited. We do not want to introduce another client library as it will complicate the application dependency. There is a pending issue for that. Thanks.

stevehu avatar May 14 '22 23:05 stevehu

@mahirgamal I have tested the HTTPS access to public sites and it works. So my previous answer was wrong. Could you please submit a PR with a test case? I will find sometime to debug into it. Thanks.

stevehu avatar May 16 '22 14:05 stevehu

@stevehu thanks for your quick response. I did open Pull Request. Cheers.

mahirgamal avatar May 16 '22 23:05 mahirgamal

Rejected the pull-request since it required adding a self-signed certificate to the trust-store.

fdutton avatar May 23 '23 01:05 fdutton