WIP: improvements & bug fixes

[JanTvrdik]

[dg]

Can you split it to tests and changes in decoder?

[JanTvrdik]

Oh, I've just noticed that tests failed on Travis which means that iconv('UTF-32BE', 'UTF-8//IGNORE', pack('N', $code)); is not portable.

[dg]

Maybe unsupported //IGNORE?

[JanTvrdik]

Another JSON incompatibility:

[
    1
    ,
    2
]

(Isolated from https://github.com/php/php-src/blob/master/ext/json/tests/pass001.1.phpt)

Edit: I've got hotfix that passed all tests but I have no idea whether it is reliable.

Edit: another two:

{"A"
:"B"}

{"A":
"B"}

[JanTvrdik]

Now all the tests passing, however the following syntax is no longer supported:

{
    "A":
    "B":
}

You now need to switch to a block mode by omitting the brackets if you want to omit values:

"A":
"B":

[JanTvrdik]

One more issue: Neon assumes block mode on top level, where whitespaces are significant and ends up with Unexpected indentation error for the following

Assert::same( TRUE, Neon::decode("\n\t[1]") );

Edit: I've tried trimming the input string, hopefully it will not break anything.

[mishak87]

@JanTvrdik Is this still work in progress?

[dg]

@JanTvrdik is this still valid?

[JanTvrdik]

Yes, partially.

[dg]

@JanTvrdik can you rebase it, it is partially implemented

[JanTvrdik]

rebased, but unfortunatelly not ready to merge as-is