application icon indicating copy to clipboard operation
application copied to clipboard

LinkGenerator: allow semicolon destination prefix

Open dakujem opened this issue 5 years ago • 4 comments

  • fixes bug #255
  • BC break? no

Allows passing semicolon-prefixed destinations to LinkGenerator::link calls:

(new LinkGenerator(...))->link(':Foo:Bar:baz');
(new LinkGenerator(...))->link(':Bar:baz');

// and also this:
(new LinkGenerator(...))->link($presenter->getAction(true));

-- closes #255

dakujem avatar Mar 24 '20 12:03 dakujem

@dg I'd be grateful if this was merged & released promptly. It would be awesome. I see praparations for next release. This should be fully compatible.

dakujem avatar Mar 25 '20 17:03 dakujem

Should I rebase this? Any plan to fix the issue?

dakujem avatar May 20 '20 19:05 dakujem

You should update your test config - PHP 7.1 is no longer your target.

dakujem avatar May 20 '20 19:05 dakujem

Do we really need to force-push to master? Isn't that what dev branches are meant for? I've needed to rebased this PR 4 times since I originally prepared it. It would be awesome to accept it already.

dakujem avatar Jul 15 '20 06:07 dakujem