nitrox icon indicating copy to clipboard operation
nitrox copied to clipboard

Some features + some fixes

Open darkweaver87 opened this issue 9 years ago • 12 comments

Hello,

Here are some non breaking modifications to make it work on an up to date mesos/marathon environment. I also added some features to make it compliant with our naming conventions :-) Please accept those.

Rémi

darkweaver87 avatar Jul 12 '16 06:07 darkweaver87

I'm on vacation right now, will test and merge next week

chiradeep avatar Jul 12 '16 08:07 chiradeep

ok no problem :-)

darkweaver87 avatar Jul 13 '16 08:07 darkweaver87

Hi, this doesn't work (due to the base64 encoding change). I can't figure out why this (base64 enc) is required.

chiradeep avatar Jul 25 '16 16:07 chiradeep

Hello,

Sorry for late answer. This is because I didn't manage to start the application with marathon with a APP_INFO containing complexe json. But I think I'll remove this and make APP_INFO be able to be loaded from a json file.

Rémi

darkweaver87 avatar Aug 24 '16 13:08 darkweaver87

cc @darkweaver87 @chiradeep is this project still valid? Looking to use this against mesos 1.9 and citrix 10.5

wallnerryan avatar Apr 13 '17 15:04 wallnerryan

Tested against NetScaler 11, I believe but should be compatible. But please raise issues if you see them.

Sent from my iPhone

On Apr 13, 2017, at 8:21 AM, Ryan Wallner [email protected] wrote:

cc @darkweaver87 @chiradeep is this project still valid? Looking to use this against mesos 1.9 and citrix 10.5

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

chiradeep avatar Apr 13 '17 15:04 chiradeep

@chiradeep thanks, We have MPX/VPX. Also is there a reason this PR was not merged?

wallnerryan avatar Apr 13 '17 15:04 wallnerryan

Didn't work

Sent from my iPhone

On Apr 13, 2017, at 8:30 AM, Ryan Wallner [email protected] wrote:

@chiradeep thanks, We have MPX/VPX. Also is there a reason this PR was not merged?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

chiradeep avatar Apr 13 '17 15:04 chiradeep

Hello wallnerryan,

Yes, we are using on our production systems since months. We have NS 10.5 and mesos 1.1.0.

Rémi

darkweaver87 avatar Apr 13 '17 19:04 darkweaver87

@darkweaver87 Thanks. Just to clarify, you are running the master branch with " NS 10.5 and mesos 1.1.0"?

We are running mesos 1.9, so i suspect some issues using this, if we find it useful and produce any fixes we will report/help contribute

wallnerryan avatar Apr 14 '17 11:04 wallnerryan

@adolforod Do you mind sharing your use case? I am in the PM team with NetScaler.

mikkodisini avatar Apr 17 '17 17:04 mikkodisini

@wallnerryan Well yes, I'm running the master branch, this pull request included: https://github.com/Cdiscount/nitrox But from what I see, I'll have to include last fixes from chiradeep

darkweaver87 avatar Apr 22 '17 09:04 darkweaver87

Cleaning some old PR, I don't think still need this.

darkweaver87 avatar Jul 10 '24 14:07 darkweaver87