framework-info icon indicating copy to clipboard operation
framework-info copied to clipboard

feat: migrate from webpack to vite

Open ericapisani opened this issue 3 years ago โ€ข 1 comments

Summary

Replaces webpack with vite to build.

Is far easier to configure and maintain.

Testing

cli

  • Pull this branch, increment the version in package.json of the package, and run npm pack
  • In build-info project, run npm install <path to the .tgz>
  • install/npm link build-info globally if you haven't already
  • run build-info <project path> against a test project
  • if working correctly, frameworks should be detected (such as a 'Next.js' site)

UI

  • do the same 1st step as for the cli
  • do the 2nd step in netlify-react-ui (rather than build-info)
  • follow the steps to start the UI locally
  • Start the flow of importing a site from a git repo
  • If working correctly, the correct framework should be detected (such as a 'Next.js' site)

For us to review and ship your PR efficiently, please perform the following steps:

  • [ ] Open a bug/issue before writing your code ๐Ÿง‘โ€๐Ÿ’ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐Ÿ”ฅ (e.g. incident related), you can skip this step.
  • [ ] Read the contribution guidelines ๐Ÿ“–. This ensures your code follows our style guide and passes our tests.
  • [ ] Update or add tests (if any source code was changed or added) ๐Ÿงช
  • [ ] Update or add documentation (if features were changed or added) ๐Ÿ“
  • [ ] Make sure the status checks below are successful โœ…

A picture of a cute animal (not mandatory, but encouraged)

IMG_20221001_175611_852

ericapisani avatar Oct 07 '22 17:10 ericapisani

Deploy Preview for framework-info ready!

Name Link
Latest commit 877718b9320fb5c2726e8a84f393551d792996f9
Latest deploy log https://app.netlify.com/sites/framework-info/deploys/634811a9d358d50008de7f1a
Deploy Preview https://deploy-preview-819--framework-info.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 07 '22 18:10 netlify[bot]

I ran build-info ../../oss/iamdeveloper.com for my blog (Eleventy) and it gave the expected output.

{
  "frameworks": [
    {
      "id": "eleventy",
      "name": "Eleventy",
      "category": "static_site_generator",
      "dev": {
        "commands": ["npm run serve"],
        "port": 8080,
        "pollingStrategies": [
          {
            "name": "TCP"
          },
          {
            "name": "HTTP"
          }
        ]
      },
      "build": {
        "commands": ["eleventy"],
        "directory": "_site"
      },
      "env": {},
      "logo": {
        "default": "https://framework-info.netlify.app/logos/eleventy/default.svg",
        "light": "https://framework-info.netlify.app/logos/eleventy/default.svg",
        "dark": "https://framework-info.netlify.app/logos/eleventy/default.svg"
      },
      "plugins": []
    }
  ]
}

nickytonline avatar Oct 11 '22 20:10 nickytonline