cli icon indicating copy to clipboard operation
cli copied to clipboard

chore: updated types for sites commands

Open benhancock opened this issue 1 year ago โ€ข 0 comments

๐ŸŽ‰ Thanks for submitting a pull request! ๐ŸŽ‰

Summary

Fixes conversion to TypeScript

  • Created Account type for Netlify accounts to correspond to response issued by listAccountsForUser API endpoint
  • typed getRepoData function signature
  • Added try/catch block to api call within getTemplatesFromGithub
  • Created RepoFromGithub and Template types for fetchTemplates function

For us to review and ship your PR efficiently, please perform the following steps:

  • [ ] Open a bug/issue before writing your code ๐Ÿง‘โ€๐Ÿ’ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐Ÿ”ฅ (e.g. incident related), you can skip this step.
  • [ ] Read the contribution guidelines ๐Ÿ“–. This ensures your code follows our style guide and passes our tests.
  • [ ] Update or add tests (if any source code was changed or added) ๐Ÿงช
  • [ ] Update or add documentation (if features were changed or added) ๐Ÿ“
  • [ ] Make sure the status checks below are successful โœ…

A picture of a cute animal (not mandatory, but encouraged)

benhancock avatar Oct 15 '24 17:10 benhancock