cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: remove to-readable-stream

Open rjbeers opened this issue 1 year ago โ€ข 1 comments

๐ŸŽ‰ Thanks for submitting a pull request! ๐ŸŽ‰

Summary

This should replace https://github.com/netlify/cli/pull/6599.

The dependency was outdated. The latest version recommends using node:streams Readable.from() to produce a nodejs stream.


For us to review and ship your PR efficiently, please perform the following steps:

  • [ ] Open a bug/issue before writing your code ๐Ÿง‘โ€๐Ÿ’ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐Ÿ”ฅ (e.g. incident related), you can skip this step.
  • [ ] Read the contribution guidelines ๐Ÿ“–. This ensures your code follows our style guide and passes our tests.
  • [ ] Update or add tests (if any source code was changed or added) ๐Ÿงช
  • [ ] Update or add documentation (if features were changed or added) ๐Ÿ“
  • [ ] Make sure the status checks below are successful โœ…

A picture of a cute animal (not mandatory, but encouraged)

rjbeers avatar Jun 02 '24 02:06 rjbeers

๐Ÿ“Š Benchmark results

Comparing with 59f84338115d6fd826b94f65f3ea1c0b7f73276a

  • Dependency count: 1,212 โฌ‡๏ธ 0.08% decrease vs. 59f84338115d6fd826b94f65f3ea1c0b7f73276a
  • Package size: 313 MB โฌ‡๏ธ 0.01% decrease vs. 59f84338115d6fd826b94f65f3ea1c0b7f73276a
  • Number of ts-expect-error directives: 976 (no change)

github-actions[bot] avatar Jun 02 '24 02:06 github-actions[bot]