cli icon indicating copy to clipboard operation
cli copied to clipboard

refactor: remove got.js utility

Open hereje opened this issue 2 years ago โ€ข 1 comments

Summary

remove got.js utility so that it is no longer referenced

related to #5695


For us to review and ship your PR efficiently, please perform the following steps:

  • [ ] Open a bug/issue before writing your code ๐Ÿง‘โ€๐Ÿ’ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐Ÿ”ฅ (e.g. incident related), you can skip this step.
  • [x] Read the contribution guidelines ๐Ÿ“–. This ensures your code follows our style guide and passes our tests.
  • [ ] Update or add tests (if any source code was changed or added) ๐Ÿงช
  • [ ] Update or add documentation (if features were changed or added) ๐Ÿ“
  • [ ] Make sure the status checks below are successful โœ…

A picture of a cute animal (not mandatory, but encouraged)

hereje avatar Dec 05 '23 21:12 hereje

๐Ÿ“Š Benchmark results

Comparing with 485aabd1c76b9b61f80e78d5c9ef9aaba9b30d54

  • Dependency count: 1,283 (no change)
  • Package size: 282 MB โฌ‡๏ธ 0.00% decrease vs. 485aabd1c76b9b61f80e78d5c9ef9aaba9b30d54
  • Number of ts-expect-error directives: 1,180 (no change)

github-actions[bot] avatar Dec 05 '23 21:12 github-actions[bot]

@hereje the tests failed again. Looks like got is still used as of now so we can't merge this PR

TylerBarnes avatar Feb 27 '24 17:02 TylerBarnes

@hereje the tests failed again. Looks like got is still used as of now so we can't merge this PR

I forgot to mention, this PR must be merged after all PR related to https://github.com/netlify/cli/issues/5695 have been merged.

hereje avatar Feb 28 '24 15:02 hereje