proteus-java icon indicating copy to clipboard operation
proteus-java copied to clipboard

Make it possible to exclude metrics & tracing when generating stubs

Open bsideup opened this issue 7 years ago • 2 comments

Hi!

Currently, the generated code contains code for the metrics & tracing, even if it's optional. Would be great to have an option to disable them at the code generation phase.

Thanks!

bsideup avatar Jul 29 '18 10:07 bsideup

Hi @robertroeser!

Anything I can help with?

Currently, we can't even use compileOnly and have to put OpenTracing & MicroMeter on the classpath because of Optional<> parameters in the constructor (JVM will fail if classes are missing)

bsideup avatar Aug 04 '18 14:08 bsideup

Hi @bsideup

If you want to take a crack making OpenTracing and Micrometer options in protoc that would be cool.
Changes would have to be made here to the protoc plugin https://github.com/netifi-proteus/proteus-java/tree/develop/protobuf-rpc/src/java_plugin/cpp

and then figure out how to send parameters to protoc to disable open tracing and micrometer

robertroeser avatar Aug 04 '18 18:08 robertroeser