netdisco
too_many_devices might be in the wrong place in the config tree
Expected Behavior
having a way to just show devices on the netmap without to much config is great. i am however not convinced that the way to change the limit is in the correct part of the config tree:
https://github.com/netdisco/netdisco/blob/85f81cf32e300551ccb7f7d0eca9a04808a5233d/share/config.yml#L166
sidebar_defaults says: "This setting is used internally by Netdisco to build web interface sidebar layouts. You could use this to change a default, which is quite simply done by overriding any key, for example"
i would argue that too_many_devices does not fit that description. it controls if the options can be seen, but it can't see that it sets a default. if so i would have expected to see the actual value in the sidebar somewhere
Current Behavior
too_many_devices does not actually set a default but controls visibility.
Possible Solution
i updated to wiki so try and give it some visibilty that this might be a value to look at, but not quite sure where to go next. i guess it can be hard on the server with to many devices, but i also feel that in the current form this feature can be easily missed.
one way could be to always show the sidebar but make too_many_devices control if the controls are enabled or greyed out, but then it's still not in the right config tree spot imo. variant of that would be to always show that sidebar piece, make it determine if the controls are enabled or not, but also show the value of too_many_devices and allow it to be set via the sidebar. adding an option to control visibilty is also a way, but that's yet another config option & we alrdy have quite some.
my personal preference is the "variant" version, but that's also the most work to code. it would however make too_many_devices be in the correct config tree part and be updated on the fly instead of via the config files.
Context
have added the current way to the wiki as an example, should the config location be changed this is also a reminder for me to update the wiki
https://github.com/netdisco/netdisco/wiki/Configuration/_compare/5602b6d9e18a549f09317c2b0333b2028f0bea25...3cd1bfcb1df52c802134590b44b398aeffa31382
Your Environment
- Netdisco version used: 2.72.2
