netZooPy icon indicating copy to clipboard operation
netZooPy copied to clipboard

added lioness dragon impl and test outline

Open katehoffshutta opened this issue 3 years ago • 1 comments

katehoffshutta avatar Oct 20 '22 10:10 katehoffshutta

Codecov Report

Base: 53.69% // Head: 54.50% // Increases project coverage by +0.81% :tada:

Coverage data is based on head (0ce9937) compared to base (e99391c). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #270      +/-   ##
==========================================
+ Coverage   53.69%   54.50%   +0.81%     
==========================================
  Files          36       37       +1     
  Lines        2302     2343      +41     
==========================================
+ Hits         1236     1277      +41     
  Misses       1066     1066              
Impacted Files Coverage Δ
netZooPy/lioness/lioness_for_dragon.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 22 '22 17:10 codecov[bot]

Is this ready to be merged? Should I wait?

violafanfani avatar Oct 28 '22 18:10 violafanfani

all good on my side, how about you @katehoffshutta ?

marouenbg avatar Oct 28 '22 19:10 marouenbg

Sorry to miss this mention earlier! Thanks for merging. This is ready for devel; needs work before master. In particular, it outputs a very large file with all the networks right now and I want to set it up with an option to write individual files for each network instead.

katehoffshutta avatar Oct 28 '22 22:10 katehoffshutta