lbfgsb-gpu icon indicating copy to clipboard operation
lbfgsb-gpu copied to clipboard

Allocation of gradient array

Open fzimmermann89 opened this issue 4 years ago • 1 comments

Hi,

first of all, thank you for making this code available!

In the readme you mention one should allocate a buffer for g. But there is no way to actually make the library use that buffer, a new buffer will always be allocated inside lbfgsbminimize. The example allocates a buffer outside, but this is never used. Do you maybe have a version of the code that allows a user to hand over the gradient buffer to use or would you accept a PR changing the API of lbfgsbminimize to accept a buffer?

-Felix

fzimmermann89 avatar Apr 06 '22 16:04 fzimmermann89

That was something in the old version. Sure! Please do submit a PR for new features. Thank you!

raymondyfei avatar Apr 06 '22 18:04 raymondyfei