giturlparse icon indicating copy to clipboard operation
giturlparse copied to clipboard
verified publisher icon nephila

Fix BitBucket regex

Open mathrick opened this issue 1 year ago • 1 comments

Description

This fixes the BitBucket regex so username@ is not required, and adds bitbucket.com as a recognised domain.

References

Fixes #107

Checklist

  • [ ] Code lint checked via inv lint
  • [x] Tests added

mathrick avatar Sep 26 '24 01:09 mathrick

Updated the PR, thanks @yarikoptic for the review!

Please note that I also had to fix the way platform defaults are applied during parsing; the old code effectively discarded any defaults that were defined. Since this is required to get the tests passing, I think it belongs in this PR, but if you'd like me to split it out into its own PR, I can do that too.

mathrick avatar Nov 28 '24 19:11 mathrick

Hello @yarikoptic , any chance to review the updates?

ivs-cetmix avatar Aug 19 '25 21:08 ivs-cetmix

Hi! Can we get this reviewed and merged please?

CC @yakky @protoroto

taminomara avatar Oct 18 '25 19:10 taminomara

Pull Request Test Coverage Report for Build 18645873186

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.833%
Totals Coverage Status
Change from base Build 18645855809: 0.02%
Covered Lines: 215
Relevant Lines: 225
💛 - Coveralls

coveralls avatar Oct 20 '25 07:10 coveralls

@mathrick Hi! Thanks for this pr! In order to make the CI pass, you should:

  • create a new branch named bugfix/issue-107-fix-bitbucked-url-parse (or whatever you like, but the bugfix/issue-107- part is the important part), and open the pr from that branch.
  • add a 107.bugfix file inside changes directory, with a brief explaination of what you did (something like Fix Bitbucked url parse and add bitbucked.com to recognized domains should be ok, or whatever you prefer)

After this we can make the CI pass and I'll merge and release a new version.

Thanks again!

protoroto avatar Oct 20 '25 08:10 protoroto

Seeing how this PR is more than a year old, I took it upon myself to rename the branch and add a changelog entry, see #118. It's just a rename, so commit authorship is intact.

taminomara avatar Oct 21 '25 19:10 taminomara

@taminomara Thanks for speeding things up! :) I've just released 0.13.0 version with these changes. I'm closing this @mathrick as it is superseeded by #118 that is already merged an released. I've updated AUTHORS.rst file with both your names, thanks again for contributing!

protoroto avatar Oct 22 '25 08:10 protoroto