DataStorehouse icon indicating copy to clipboard operation
DataStorehouse copied to clipboard

Validation improvements

Open Bchass opened this issue 2 years ago • 12 comments

Description

Cleaned up the code to make it more readable and minimized some of the repetitiveness that existed. Renamed the file from Main.py to validate.py. This also includes the ability for the terminal to ask which file you would like to analyze and then automatically opens the report generated.

Related Issues

N/A

Changes Made

  • Added open_report()
  • Renamed file_type() to analyze_file() and cleaned this file up a good amount
  • Replaced all with open(report_file, 'a') as file: with open_report() and a f-string for easier readability
  • Created main() at the bottom of the file that now handles the terminal workflow and opening the report automatically

Screenshots (if applicable)

Screenshot 2023-10-01 at 7 29 04 PM

Checklist

Please review and check the following before submitting your pull request:

  • [x] I have followed the project's coding conventions and guidelines
  • [x] I have tested my changes thoroughly
  • [ ] I have added/updated relevant documentation
  • [x] My code follows best practices and is easy to understand
  • [ ] I have added necessary test cases (if applicable)
  • [ ] All existing tests are passing
  • [x] My changes do not introduce any new warnings or errors

Additional Notes

N/A

Bchass avatar Oct 01 '23 23:10 Bchass

Someone is attempting to deploy a commit to a Personal Account owned by @neokd on Vercel.

@neokd first needs to authorize it.

vercel[bot] avatar Oct 01 '23 23:10 vercel[bot]

Screenshot 2023-10-01 at 8 23 32 PM

Gave it more of a pleasant looking prompt

Bchass avatar Oct 02 '23 00:10 Bchass

@Bchass is this under hacktoberfest?

neokd avatar Oct 02 '23 05:10 neokd

@Bchass appreciation for your work, can you modify your code that user can give their own directory path so that they can run this code on any dataset.

Gladwin001 avatar Oct 02 '23 07:10 Gladwin001

@Bchass is this under hacktoberfest?

Not originally when I first started on these changes. But now I can see a new issue open regarding data validation.

Bchass avatar Oct 02 '23 11:10 Bchass

Yeah that's regarding generation of an entire report like format for each dataset.we'll slowly develop more on that issue into chunks so can work with any type of dataset

neokd avatar Oct 02 '23 12:10 neokd

@Bchass appreciation for your work, can you modify your code that user can give their own directory path so that they can run this code on any dataset.

Added the requested functionality

Bchass avatar Oct 02 '23 13:10 Bchass

For printing the data store house we can use a existing python pip package which does this for us.

Package name?

Bchass avatar Oct 08 '23 17:10 Bchass

For printing the data store house we can use a existing python pip package which does this for us.

Package name?

There are multiple terminal enhancement packages. https://pypi.org/project/art/ - this will help you create a similar visualization you implemented using print.

few other I got from search https://github.com/Textualize/rich/tree/master#rich-library https://pypi.org/project/simple-term-menu/

VigneshRamanathan101 avatar Oct 09 '23 03:10 VigneshRamanathan101

@Gladwin001 , @Bchass anything more to add on this PR?

neokd avatar Oct 16 '23 15:10 neokd

I'm all set on my end

Bchass avatar Oct 16 '23 15:10 Bchass

@Bchass Thanks for all your contribution 🥇 🌟

neokd avatar Oct 17 '23 07:10 neokd