NeoForge icon indicating copy to clipboard operation
NeoForge copied to clipboard
verified publisher icon neoforged

[1.20.5] `minecraft:stored_enchantments` item subpredicate does not function

Open ChrysanthCow opened this issue 2 years ago • 4 comments

Minecraft Version: 1.20.5

NeoForge Version: 20.5.20-beta

Logs: https://mclo.gs/bjV9DXR

Steps to Reproduce:

  1. Download this datapack.
  2. Put it in your world folder.
  3. Give yourself an Aqua Affinity enchanted book.
  4. Run the command /item modify entity @s weapon.mainhand test:oops.
  5. It does not work on NeoForge, but works on vanilla.

Description of issue: The minecraft:stored_enchantments item subpredicate does not function properly. This is because there is no component check to make sure that the enchantments specified are base enchantments before applying the NeoForge enchantment changes.

Vanilla Instance: image

NeoForge Instance: image

ChrysanthCow avatar Apr 29 '24 02:04 ChrysanthCow

The datapack download link does not seem to be working for me

TelepathicGrunt avatar May 17 '24 12:05 TelepathicGrunt

Alright, I'll send a better link over.

ChrysanthCow avatar May 17 '24 19:05 ChrysanthCow

https://wormhole.app/xEkAx#u-J2X6NuMZ_l3RTrxW3AMA. This will only last for 24h as of sending.

ChrysanthCow avatar May 17 '24 19:05 ChrysanthCow

Ok got the datapack. Posting it here directly so it stays forever for future testing purposes. With github, you can upload up to 10mb files here without needing external links

neoforge report.zip

TelepathicGrunt avatar May 17 '24 19:05 TelepathicGrunt