express-partial-response icon indicating copy to clipboard operation
express-partial-response copied to clipboard

Use and enforce Prettier

Open nemtsov opened this issue 7 years ago • 5 comments

Let's use https://github.com/prettier/prettier to make the style consistent.

  • [ ] Use the --single-quote option please (either as an option or as a config; depending on how you implement it
  • [ ] Make sure the style is enforced when npm test is run

nemtsov avatar Mar 06 '18 15:03 nemtsov

@qm3ster are you, by any chance, interested in taking this one?

nemtsov avatar Mar 06 '18 15:03 nemtsov

Only if I get to do semi: false

qm3ster avatar Mar 06 '18 16:03 qm3ster

Only if I get to do semi: false

Ha! I'll agree to that if you can be certain that anyone wanting to contribute to the source of this repo can recite the Rules of Automatic Semicolon Insertion; and if not, let's just keep semicolons and not have to ever think about those. And I say this after having converted most of my repos to no-semis, seen the issues and regretted having converted them in the first place.

Less code is good; less thinking is better.

nemtsov avatar Mar 06 '18 16:03 nemtsov

You didn't have to recite your history to me, I saw your reply about code style on the other PR and went through your repo to see that it was eslint semis -> eslint standard -> prettier semis. I was, shocked, appalled, and instead of converting to prettier no semis had to resign to eslint standard-ish

qm3ster avatar Mar 06 '18 17:03 qm3ster

If you're still into doing this @qm3ster , I have a clonable setup here: https://github.com/nemtsov/connect-chokidar

nemtsov avatar Mar 18 '18 04:03 nemtsov