phpFinTS icon indicating copy to clipboard operation
phpFinTS copied to clipboard

Add getters and setters for kundensystemId (#453)

Open roben opened this issue 1 year ago • 2 comments

Adds getters and setters for kundensystemId, see #453.

roben avatar Oct 10 '24 13:10 roben

I have a sense that this would allow implementing an imperfect workaround for #458 outside the library, i.e. in the user application code. Let's try to address #458 inside the library instead.

Philipp91 avatar Oct 11 '24 15:10 Philipp91

Merge? :thinking:

nemiah avatar Oct 13 '24 08:10 nemiah

I have a sense that this would allow implementing an imperfect workaround for #458 outside the library, i.e. in the user application code.

My impression was wrong. #458 has two parts: The refreshing of the ID still isn't implemented today and the gettter/setter proposed in this PR have nothing to do with that. The persisting of the ID is already done by standard persist(), but for applications that don't use this API (or only use it between login/action and TAN confirmation, i.e. during one session and not between sessions), the getter/setter in this PR can be an alternative. While I don't fully understand why people prefer this over persist(true), I wouldn't mind merging this PR for such use cases. Especially if the alternative is for people to fork the library or edit it after installing it through Composer, just to apply this one patch.

Philipp91 avatar Nov 08 '25 22:11 Philipp91