phpFinTS icon indicating copy to clipboard operation
phpFinTS copied to clipboard

fix #354: Sammelüberweisung

Open carli2 opened this issue 3 years ago • 9 comments

We implemented the feature and would like to get it mainstream

https://launix.de/launix/launix-unterstuetzt-die-freie-fints-schnittstelle-phpfints/

carli2 avatar Feb 23 '22 17:02 carli2

Copyright marks are fine with MIT. Every author gains copyright by creating a piece of work automatically. By publishing it, the code additionally gets licensed under MIT, so everyone can use it.

We wrote the copyright notice this way because the author differs from the copyright holder.

carli2 avatar Feb 23 '22 18:02 carli2

Thanks for the review. I will look into it and make changes tomorrow.

LaunixPeter avatar Feb 24 '22 09:02 LaunixPeter

To fix the Travis failures, see here.

Philipp91 avatar Feb 24 '22 19:02 Philipp91

Will anyone fix this one?

nemiah avatar Aug 26 '22 04:08 nemiah

As far as we can see, Travis CI yields some false positives. Correct me if I'm wrong.

carli2 avatar Jan 26 '23 06:01 carli2

Do I undestand it correctly that even with BtchBookg set to false I would still be allowed to submit multiple transfers with a single TAN while having each transfer listed as a single transaction by the bank? It would be awesome to have this added to the library.

roben avatar Jan 30 '23 15:01 roben

Do I undestand it correctly that even with BtchBookg set to false I would still be allowed to submit multiple transfers with a single TAN while having each transfer listed as a single transaction by the bank? It would be awesome to have this added to the library.

No. But you can encode multiple transfers in a single SEPA file and submit this file with one single TAN which basically yields the same result.

We already forked the library to have this feature in our software.

carli2 avatar Jan 30 '23 15:01 carli2

But you can encode multiple transfers in a single SEPA file and submit this file with one single TAN which basically yields the same result.

That's what I meant. Are those transactions then listed by the bank individually or all together as a single "Sammelauftrag"? As I understood it, the flag BtchBookg governs this behavior (https://www.sparkasse-landsberg.de/content/dam/myif/spk-landsberg-diessen/work/dokumente/pdf-ll/SEPA%20FAQs.pdf) but I did not find any information if multiple transfers in a single XML file are possible at all with BtchBookg = false

roben avatar Jan 30 '23 15:01 roben

As far as we can see, Travis CI yields some false positives. Correct me if I'm wrong.

I dont think so. I encountered this issue before. Because this repo has no composer.lock file (because of the different php versions), you have to be carefull to delete your own lock file, then do a composer update / install and only then the composer cs-fix.

If this is the problem, we should add this to the linked passage

To fix the Travis failures, see here.

lukas-staab avatar Feb 15 '23 19:02 lukas-staab