Replace submodule by jar inclusion to reference editorconfig-java

[mickaelistria]

Currently, the code copies the source of editorconfig-java to build. This is not safe because remote code can change and break the build. It seems better to consume directly the jar of a specific version using Maven.

[ncjones]

I agree in principle but last time I checked the editorconfig Java project will require adding OSGi manifest. The submodule is a hack but it is pinned to a commit id so it is not unsafe.

[mickaelistria]

MANIFEST.MF isn't necessarily. If we have it has a jar in a Maven repository, it's only a matter of:

• Using maven-dependency-plugin in pom to fetch it at build-time
• Adding it to the build.properties to have it included in plugin jar
• Adding it to a Bundle-Classpath directive in editorconfig-eclipse to have it visible at runtime

[ncjones]

OK that's great. I think the jar wasn't in maven central at the time I started this project. On 26 May 2016 2:06 a.m., Mickael Istria [email protected] wrote:MANIFEST.MF isn't necessarily. If we have it has a jar in a Maven repository, it's only a matter of:

Using maven-dependency-plugin in pom to fetch it at build-timeAdding it to the build.properties to have it included in plugin jarAdding it to a Bundle-Classpath directive in editorconfig-eclipse to have it visible at runtime

—You are receiving this because you commented.Reply to this email directly or view it on GitHub

[mickaelistria]

OK that's great. I think the jar wasn't in maven central at the time I started this project.

Apparently, it's still not published: https://github.com/editorconfig/editorconfig-core-java/issues/6

[ppalaga]

@ncjones you might be interested in looking at ec4j [1] (a new .editorconfig Java parser) that was just released to central [2]

[1] https://github.com/ec4j/ec4j [2] http://central.maven.org/maven2/org/ec4j/core/ec4j-core/