backpex icon indicating copy to clipboard operation
backpex copied to clipboard

Fix item action guide

Open krns opened this issue 1 year ago • 1 comments

krns avatar Jul 31 '24 18:07 krns

Currently, the item action confirmation dialog is enabled when the list of fields is empty or the confirm/1 function is exported (see has_modal?/1).

From our docs:

To enable the confirmation dialog you need to implement the confirm_label/1 function

This doesn't seem right and has to be updated.

Moreover, we should update the has_modal?/1 function because you always need the confirm/1 function if there is a list of fields.

@krns

Flo0807 avatar Aug 08 '24 07:08 Flo0807

See https://github.com/naymspace/backpex/pull/760

Flo0807 avatar Jan 10 '25 09:01 Flo0807