ui-chart icon indicating copy to clipboard operation
ui-chart copied to clipboard

added support for setting and getting clipHighlightToContent

Open marbelsy opened this issue 2 years ago • 1 comments

PR Checklist:

  • [ x] I have tested this extensively and it does not break any existing behavior.
  • [ x] I have added/updated examples and tests for any new behavior.
  • [ ] If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

Added support for getting and setting clipHighlightToContent.

Added function setClipHighlightToContent and isClipHighlightToContentEnabled (same style as as setting the clipping of data and values) in order to allow the highlight to be drawn outside of the content area without bleeding out graphs.

As the variable was already present but lacked the functions to set / get this seemed like a "missing" feature

marbelsy avatar Mar 23 '23 07:03 marbelsy

@mBaldasty actually this is not needed as the property is public ? I have an on going heavy and breaking task to remove all those getter and setter and use properties instead. The idea is to reduce the size of the lib which is pretty big right now.

Can you confirm you can still use it without the getter and setter ?

farfromrefug avatar Mar 23 '23 13:03 farfromrefug