react-native-custom-qr-codes icon indicating copy to clipboard operation
react-native-custom-qr-codes copied to clipboard

Works really slow if data length > 54 chars on low-end devices

Open Overtorment opened this issue 7 years ago • 6 comments

Overtorment avatar Jan 10 '19 14:01 Overtorment

Takes literally minutes to render (on low-end android devices)

Overtorment avatar Jan 10 '19 14:01 Overtorment

@Overtorment I see the same issue. I have not looked at the code yet but it appears that a promise is not being used at a point where it perhaps should be. The call to create the QRCode is synchronous, perhaps breaking it up will help. @nating PLEASE PLEASE could you help with this?

I am using version 2.0.0 and the content I use looks like this:

ndap34mk6yzyiru49ivfitgzybkfqxnejcr9qvtnd3ychb20

kristoferpelchat avatar Apr 11 '19 19:04 kristoferpelchat

@kristoferpelchat I think we migrated to smth nicer and faster, check deps here https://github.com/BlueWallet/BlueWallet/

Overtorment avatar Apr 11 '19 19:04 Overtorment

@kristoferpelchat I think we migrated to smth nicer and faster, check deps here https://github.com/BlueWallet/BlueWallet/

FANTASTIC! I upgraded and it is working. thanks @Overtorment. It just so happens we are creating a wallet as well that will eventually be public on Github (https://ndau.io). :)

kristoferpelchat avatar May 17 '19 13:05 kristoferpelchat

@kristoferpelchat what is smth? I'm working through this issue since it's so slow on android, though it worked for awhile. Thanks!

MeKyleH avatar Sep 27 '19 05:09 MeKyleH

@kristoferpelchat what is smth? I'm working through this issue since it's so slow on android, though it worked for awhile. Thanks!

react-native-qrcode-svg is where we landed.

kristoferpelchat avatar Sep 27 '19 08:09 kristoferpelchat