Transcoder icon indicating copy to clipboard operation
Transcoder copied to clipboard
verified publisher icon natario1

Initialize mOriginUs lazily

Open jumperson opened this issue 4 years ago • 3 comments

#138 Library transcode video with artifacts. Link to video

I have same issue.

I checked the diffs for v0.9.1 and v0.10.0 and found that there was an issue at https://github.com/natario1/Transcoder/commit/997de452835899f04d38913571e3ce601668fa6a .

After proceeding with the verification, it seems that some terminals have side effects with mExtractor.selectTrack(i) and mExtractor.unselectTrack(i) .

Therefore, I changed the timing to set mOriginUs .

jumperson avatar Jan 30 '22 23:01 jumperson

@natario1 Thank you for developing a great library. I would appreciate it if you could review the fix.

jumperson avatar Feb 01 '22 13:02 jumperson

Hello @jumperson I have tried the changes from the fork and transcoding a video with the buffer.hasRemaining issue, it seems to get in an infinite loop.

In my case any video downloaded from TikTok produces that issue on an Android 12 device.

tudormarze avatar Aug 26 '22 11:08 tudormarze

Hello @tudormarze. Can you try taking in both #158 and #167 ? Or the main branch of StudistCorporation/Transcoder has both #158 and #167, so try it.

jumperson avatar Aug 31 '22 13:08 jumperson