Use favicon

[jakoblorz]

Warning: Opinionated Pull Request

It is unclear if the favicon was dropped on purpose, but favicons improve recognition across devices. Missing out the favicon does not prevent the browser to display something: here on my personal rig, chrome on linux shows a empty rectangle / page icon instead. Combined with the title "👋 Hello, GitHub ", it looks like something is broken.

This is why I took the freedom to (in my opinion) improve the page:

1. Added the waving hand emoji from twitter's open source emoji collection as favion.png; emojis are subject to CC-BY 4.0, check compliance
2. Added the favicon into the default.html layout
3. Altered order of the header to ensure that the tab will not show two emojis next to each other
   • Before: 👋 Hello, GitHub
   • After: Hello, GitHub 👋

If you want to affiliate this hello blog directly with GitHub, you could also use GitHub's Octocat favicon:

I wish you a good hand with GitHub @natfriedman

[armudgal]

All the best @natfriedman :)

[levrik]

@jakoblorz I think that would look weird on Windows to keep the emoji in the title since it's displayed with colors here.

[jakoblorz]

@levrik yeah, I am aware of that. The problem is that removing the title emoji completely would require the :wave: emoji to be removed from the post's title. The post's title is reused as the title of the whole page (which makes sense from a frontend hierarchy perspective). I tried to bridge this problem by moving the emoji in the title. Maybe someone can find a workaround for that - some kind of Gem which removes emojis from jekyll posts before adding them as the page's title.

What I already tried is to remove the emoji and integrate the favicon.png in the posts markup: [wave]({{ "/favicon.png" | absolute_url }}) Hello, GitHub

That solves the problem but obiously brings the title emoji completely out of proportion.

[amin007]

wow amazing