ci_lab
ci_lab copied to clipboard
off-by-one error in `CI_LAB_ReadUpLink()`
Checklist
- [x] I reviewed the Contributing Guide.
- [x] I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.
Describe the bug Based on the comment: https://github.com/nasa/ci_lab/blob/8c43b9eb45f2fe9ee5a8069cf07b2b45e3669971/config/default_ci_lab_internal_cfg.h#L43-L46
... CI_LAB_ReadUpLink() will execute one time more than expected (due to the <= in the for condition):
https://github.com/nasa/ci_lab/blob/8c43b9eb45f2fe9ee5a8069cf07b2b45e3669971/fsw/src/ci_lab_app.c#L213-L221
Expected behavior
Execute exactly as many times as expected - if starting at 0, will need to change this to =, rather <=.
Reporter Info Avi Weiss @thnkslprpt