Samples icon indicating copy to clipboard operation
Samples copied to clipboard

Wifi DeviceName has been added

Open zandiarash opened this issue 2 months ago • 2 comments

Description

I have an ESP32-32D N4 chip When it connects to the hotspot as a client the device (default) name is nanodevice_31708 I want to change that but I did not found any way to do so (I read the documentation and samples). I decided to implement that feature as Arduino has. I’ve changed these projects

  • NanoSamples
  • nf-interpreter
  • System.Device.Wifi

Motivation and Context

Now we can set the device name before it connects to any hotspot, router, access point and etc. Please read these : https://github.com/nanoframework/nf-interpreter/pull/3243 https://github.com/nanoframework/System.Device.Wifi/pull/322

How Has This Been Tested?

I should mention that I am not familiar with C++ and after I changed nf-interpreter project I flashed my chip like this

nanoff --platform esp32 --target ESP32_REV3 --serialport COM6 --update  --clrfile "D:\Sources Electronic\Nanoframework - Copy\nf-interpreter\build\nanoCLR.bin"

Screenshots

Before : x After : x

Types of changes

  • [x] Improvement (non-breaking change that improves a sample)
  • [ ] Bug fix (fixes an issue with a current sample)
  • [ ] New Sample (adds a new sample)
  • [ ] Config and build (change in the configuration and build system, has no impact on code or features)
  • [ ] Documentation/comment (fixes and improvements documentation related)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

zandiarash avatar Nov 30 '25 11:11 zandiarash

@zandiarash I've fixed the checklist for you. FYI, the correct format is [x], no spaces inside brackets, no other chars.

nfbot avatar Nov 30 '25 11:11 nfbot

[!IMPORTANT]

Review skipped

Review was skipped due to path filters

:no_entry: Files ignored due to path filters (1)
  • samples/Wifi/ScanWiFi/Program.cs is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 30 '25 11:11 coderabbitai[bot]