etherscan-api icon indicating copy to clipboard operation
etherscan-api copied to clipboard

Improve GetLogs function

Open FournyP opened this issue 2 years ago • 1 comments

Hi,

I've improved the GetLogs function because some of mandatory parameters are not mandatory for the etherscan API (e.g: toBlock, fromBlock and topic).

I've also add missing parameter page and offset.

Tests execution: image

Feel free to ask me any change in my codebase

Have a good day ;)

FournyP avatar Oct 28 '23 09:10 FournyP

Hi, @FournyP , thanks for your contribution!

I would love to see it merged but we cannot alter an existed API. I recommend to implement it as a new method GetLogsByAddr(or choose a name in your flavor).

Cheers.

nanmu42 avatar Oct 28 '23 12:10 nanmu42