Winkerberos Support, ldap3 MD4 Bug Fix

Open ehlewis opened this issue 1 year ago • 1 comments

Added dependencies required for BloodHound to utilize Kerberos. Fixed an issue in the version of ldap3 that was zipped in the repo that occurred in NTLM handling when MD4 is not already available on the system. If this was the case, ldap3 would try to load the MD4 module from Crypto which is a dependency we did not have. The adjusted version will load MD4 from Cryptodome, which we are already have. This is a known and supported fix as per https://github.com/cannatag/ldap3/issues/1051

Oct 10 '24 06:10 ehlewis

Hi, thanks a lot for you PR. Could you provide the link of the original python packages (winkerberos, ldap3) that you modified and the diff command output so I can review the differences more easily? Could you provide also a screenshot of a Pyramid working test case using the PR? Lastly, I noticed that the ldap3.zip has two nested ldap3 folders before reaching init.py, there shouldn't be nested root folders in the zip.

Regards

Dec 02 '24 03:12 naksyn